Michael Kublin has posted comments on this change.

Change subject: webadmin: Import Template Redesign (#840280)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 290:                     tempVar.setPostZero(disk.isWipeAfterDelete());
Line 291:                     
tempVar.setSourceDomainId(getParameters().getSourceDomainId());
Line 292:                     tempVar.setForceOverride(true);
Line 293:                     tempVar.setImportEntity(true);
Line 294:                     tempVar.setEntityId(disk.getImageId());
please change these, why we are using 
getParameters().getVmTemplate().getDiskList() these instead of 
getParameters().getImages()
Line 295:                     for (DiskImage diskImage : 
getParameters().getVmTemplate().getDiskList()) {
Line 296:                         if 
(diskGuidList.get(i).equals(diskImage.getId())) {
Line 297:                             
tempVar.setQuotaId(diskImage.getQuotaId());
Line 298:                             break;


--
To view, visit http://gerrit.ovirt.org/7528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib874cdd9395c14cdc724d5e97047476346ca0cf0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to