Muli Salem has uploaded a new change for review.

Change subject: core: Set Vds Only When Vm is UP (#850854)
......................................................................

core: Set Vds Only When Vm is UP (#850854)

https://bugzilla.redhat.com/850854

This patch makes sure that setVdsId is only
done in PlugUnPlugVmNicCommand if the Vm
is running.

Change-Id: I6f4fbf069555f6eb8cadd07d9a80a40ec0923013
Signed-off-by: Muli Salem <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/7543/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java
index f4ae0d9..e2cf00d 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java
@@ -31,9 +31,9 @@
         boolean returnValue = true;
 
         if (isActivateDeactivateAllowedForVmStatus(getVm().getstatus())) {
-            setVdsId(getVm().getrun_on_vds().getValue());
             // HotPlug in the host needs to be called only if the Vm is UP
             if (VmHandler.isHotPlugNicAllowedForVmStatus(getVm().getstatus())) 
{
+                setVdsId(getVm().getrun_on_vds().getValue());
                 returnValue = canPerformHotPlug();
             }
         } else {


--
To view, visit http://gerrit.ovirt.org/7543
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f4fbf069555f6eb8cadd07d9a80a40ec0923013
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to