Liron Aravot has posted comments on this change.

Change subject: core: added information to ConnectStorageVDScommand logs 
(#835546)
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_server_connections.java
Line 233:     public String toString() {
Line 234:         StringBuilder sb = new StringBuilder();
Line 235:         sb.append("{ id: ");
Line 236:         sb.append(this.getid());
Line 237:         sb.append(", connection: ");
because of the different types and the relation between them it will make the 
code kind of complicated to read and maintain.
Line 238:         sb.append(this.getconnection());
Line 239:         sb.append(", iqn: ");
Line 240:         sb.append(this.getiqn());
Line 241:         sb.append(", vfsType: ");


--
To view, visit http://gerrit.ovirt.org/5748
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b613bd18ef9586040862cac56373705f3e65237
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to