Allon Mureinik has posted comments on this change.
Change subject: core: Add warning message to log when running VM stateless
(#834891)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 259: ResumeVm();
Line 260: } else { // run vm
Line 261: if (!_isRerun &&
Boolean.TRUE.equals(getParameters().getRunAsStateless())
Line 262: && getVm().getstatus() != VMStatus.Suspended)
{
Line 263: if (getVm().getDiskList().isEmpty()) {
Pleas add a comment to explain that if there are no snapable disks, then
stateless is meaningless.
Line 264: warnIfNotAllDisksPermitSnapshots();
Line 265: RunVm();
Line 266: }
Line 267: else {
....................................................
Commit Message
Line 4: Commit: Tal Nisan <[email protected]>
Line 5: CommitDate: 2012-08-28 17:31:01 +0300
Line 6:
Line 7: core: Add warning message to log when running VM stateless (#834891)
Line 8:
Please add a bugzilla link, as per the template.
Line 9: Add a warning message to the log when running a VM with non snappable
Line 10: disks as stateless
Line 11:
Line 12: Change-Id: I6c7421f45dfa75847482a7abd23ddb5feb7d6f9e
--
To view, visit http://gerrit.ovirt.org/7539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c7421f45dfa75847482a7abd23ddb5feb7d6f9e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
