Alon Bar-Lev has posted comments on this change.

Change subject: aaa : Add engine sso
......................................................................


Patch Set 32:

(1 comment)

http://gerrit.ovirt.org/#/c/36119/32/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java
File 
backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java:

Line 56: 
Line 57:             String principal = 
principalRecord.get(Authz.PrincipalRecord.PRINCIPAL);
Line 58:             Map<String, Object> payload = new HashMap<>();
Line 59:             payload.put("userId", userId);
Line 60:             payload.put(VERSION, SSO_VERSION);
not sure why VERSION has constant and "userName" does not :)))
Line 61:             payload.put("userName", principal != null ? principal : 
principalRecord.<String>get(Authz.PrincipalRecord.NAME));
Line 62:             payload.put("email", 
principalRecord.<String>get(Authz.PrincipalRecord.EMAIL));
Line 63:             payload.put("groupIds", 
getGroupIds(config.getSsoUserGroupManager(), authzName, principalRecord));
Line 64:             payload.put("profile", 
session.getAttribute(SSOUtils.SSO_PROFILE_ATTR_NAME));


-- 
To view, visit http://gerrit.ovirt.org/36119
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to