Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Showing the fault error in the multipleActions error dialog ......................................................................
webadmin: Showing the fault error in the multipleActions error dialog In most of the commands the canDoActionMessages contain the '$action' and the '$type' replacements, no matter if the canDo passed or not. Since FrontendEventsHandlerImpl.runMultipleActionsFailed checked the canDoActionMessages size in order to decide wherer to show the canDo errors or the fault, the fault was rarely (if ever) displayed. Change-Id: I91819e7d67bbd76ec7c183608e0d0abbd70908ee Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/37724/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java index 0e6d7f8..b65f4c9 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java @@ -68,7 +68,7 @@ if (isRaiseErrorModalPanel(actions.get(actionNum++), v.getFault())) { String description = (v.getDescription() != null && !"".equals(v.getDescription().trim())) || returnValues.size() == 1 ? v.getDescription() : ConstantsManager.getInstance().getConstants().action() + " " + actionNum; //$NON-NLS-1$ //$NON-NLS-2$ - if (!v.getCanDoActionMessages().isEmpty()) { + if (!v.getCanDoAction()) { for (String canDo : v.getCanDoActionMessages()) { errors.add(new Message(description, canDo)); } -- To view, visit http://gerrit.ovirt.org/37724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I91819e7d67bbd76ec7c183608e0d0abbd70908ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
