Liron Aravot has posted comments on this change. Change subject: core: End VM export gracefully upon failure in updating OVF ......................................................................
Patch Set 1: Allon, we indeed need to perform a rollback on that scenario. Furthermore, we need to fix the audit log if we do go on that direction - the user will get an audit log of success while the operation failed (which will lead him to think that the export succeeded..a "normal" user might delete the original vm after that and lose his data). . I'm not sure that we want to fix that issue that way, its rare enough that the export fails on the ovf part and it could mean that either something is horribly wrong (like the scnario described in the bug) or some other error. if we do not want unlimited number of retries we should use the command persistency imo to limit the number of retries (it can be a config value), but not to try only one time (export of vm can take two days..we copy large amounts of data - it might be annoying to start it all over again because of one failure to update the ovf). -- To view, visit http://gerrit.ovirt.org/37583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa719e8872a69de5b3d3fa79758e12e7b63f80f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
