Yair Zaslavsky has posted comments on this change. Change subject: core: Removing unneeded signalAll ......................................................................
Patch Set 1: (1 inline comment) one typo. Besides that - good job! .................................................... Commit Message Line 6: Line 7: core: Removing unneeded signalAll Line 8: Line 9: The following patch should remove unneeded signalAll from InMemoryLockManager.acquireLockWait Line 10: The following signallAll is not needed because of all threads will weak up during releaseLock. please replace weak with wake Line 11: The signalAll removed from InMemoryLockManager.acquireLockWait in order not to cause unneeded Line 12: busy wait for waiting threads Line 13: Line 14: Change-Id: I21974c2043eee97edaf09a7006a2ac6f25c6e194 -- To view, visit http://gerrit.ovirt.org/7561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21974c2043eee97edaf09a7006a2ac6f25c6e194 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
