Alex Lourie has posted comments on this change.

Change subject: packaging, tools: Use JVM selected during setup (#834436)
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh
Line 245: then
Line 246:     NOTIFIER_PID=/dev/null
Line 247: fi
Line 248: 
Line 249: "${JAVA_HOME}/bin/java" -cp .:$CP $JAVA_OPTS 
org.ovirt.engine.core.notifier.Notifier $CONF_FILE 2>/dev/null &
is exec needed here?
Line 250: 


--
To view, visit http://gerrit.ovirt.org/7556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I501e5e5cca615f5bfffef225d9ebb3204f16b7c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to