Omer Frenkel has posted comments on this change.
Change subject: core: Host can not be restarted by ...(#852464)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java
Line 19: }
Line 20:
Line 21: @Override
Line 22: protected boolean canDoAction() {
Line 23: boolean retValue = super.canDoAction();
i know, what is asked is, ig parent is restart, why calling super?
or in other words, why the if statement you added is not on all the code as it
was before?
Line 24: if (getParameters().getParentCommand() ==
VdcActionType.Unknown) {
Line 25: if (getVds() != null && getVds().getstatus() !=
VDSStatus.Maintenance) {
Line 26:
addCanDoActionMessage(VdcBllMessages.VDS_STATUS_NOT_VALID_FOR_STOP);
Line 27: retValue = false;
--
To view, visit http://gerrit.ovirt.org/7559
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a0bf8ace353047274290f309fd0468d6e9c8b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
