Omer Frenkel has posted comments on this change.
Change subject: engine: Cluster with Virt and Gluster enabled - configurable
......................................................................
Patch Set 2: (2 inline comments)
missing apperrors.properties for both backend and frontend, please see wiki on
messages
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java
Line 81: }
Line 82:
Line 83: protected boolean isAllowClusterWithVirtGluster() {
Line 84: Boolean allowVirGluster = Config.<Boolean>
GetValue(ConfigValues.AllowClusterWithVirtGlusterEnabled);
Line 85: if (allowVirGluster == null) {
no need for this check, it shouldn't be null
Line 86: allowVirGluster = Boolean.TRUE;
Line 87: }
Line 88: return allowVirGluster;
Line 89: }
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
Line 346: VM_WITH_SAME_NAME_EXIST=VM with the same name already exists.
Line 347: SNAPSHOT_FAILED=Live snapshot failed.
Line 348: # Gluster engine errors
Line 349: NO_UP_SERVER_FOUND=No server found in Up status.
Line 350: VDS_GROUP_ENABLING_BOTH_VIRT_AND_GLUSTER_SERVICES_NOT_ALLOWED =
Creating a Cluster with both Virt and Gluster services enabled is not supported
this is not relevant in this file, VdcBellMessages is for canDoAction and
needed in AppErrors only
--
To view, visit http://gerrit.ovirt.org/7453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c501501545f35ee445861f71ec3c7197d66e06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
