Ori Liel has posted comments on this change.
Change subject: restapi: making gluster enums lower case in request/response
......................................................................
Patch Set 6: Looks good to me, approved
(1 inline comment)
Looks good :)
I had one comment, it's not major.
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapper.java
Line 181: @Mapping(from =
org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeType.class,
to = String.class)
Line 182: public static String
map(org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeType
glusterVolumeType,
Line 183: String template) {
Line 184: switch (glusterVolumeType) {
Line 185: case DISTRIBUTE:
If you use .value() instead of .name(), you won't have to .toLowerCase() it
later (same is true for all places below that use .name())
Line 186: return GlusterVolumeType.DISTRIBUTE.name();
Line 187: case REPLICATE:
Line 188: return GlusterVolumeType.REPLICATE.name();
Line 189: case DISTRIBUTED_REPLICATE:
--
To view, visit http://gerrit.ovirt.org/6093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aeec51d82ad650b9e1364295e6794e0b0861618
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
