Moti Asayag has posted comments on this change. Change subject: engine: adding 'passthrough' property to vnicProfile ......................................................................
Patch Set 1: Code-Review-1 (3 comments) minor comments regarding unit-test http://gerrit.ovirt.org/#/c/37719/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VnicProfileDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VnicProfileDaoTest.java: Line 79: assertNotNull(result); Line 80: assertEquals(FixturesTool.VM_NETWORK_INTERFACE_PASSTHROUGH_PROFILE, Line 81: result.getId()); Line 82: assertEquals(true, result.isPassthrough()); Line 83: } please replace with assertTrue() Line 84: Line 85: /** Line 86: * Ensures that an empty collection is returned. Line 87: */ Line 135: VnicProfile result = dao.get(vnicProfile.getId()); Line 136: assertNotNull(result); Line 137: assertEquals(vnicProfile.getId(), result.getId()); Line 138: assertEquals(false, result.isPortMirroring()); Line 139: assertEquals(false, result.isPassthrough()); please replace with assertFalse() Line 140: } Line 141: Line 142: /** Line 143: * Ensures that the update is working correctly Line 151: VnicProfile result = dao.get(vnicProfile.getId()); Line 152: assertNotNull(result); Line 153: assertEquals(vnicProfile.getId(), result.getId()); Line 154: assertEquals(true, result.isPortMirroring()); Line 155: assertEquals(true, result.isPassthrough()); please replace with assertTrue() Line 156: } Line 157: Line 158: /** Line 159: * Ensures that the remove is working correctly -- To view, visit http://gerrit.ovirt.org/37719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed7e63ad66aa2f5dc7584c96202a5f0c1ab1522 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
