Itamar Heim has posted comments on this change.

Change subject: webadmin: Gluster Volume - Optimize for Virt Store action
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 418:             GlusterVolumeEntity volume = (GlusterVolumeEntity) item;
Line 419:             GlusterVolumeOptionEntity option = new 
GlusterVolumeOptionEntity();
Line 420:             option.setVolumeId(volume.getId());
Line 421:             option.setKey("group"); //$NON-NLS-1$
Line 422:             option.setValue("rhev"); //$NON-NLS-1$
I'm missing an explanation what does group rhev means/does?
Line 423:             list.add(new GlusterVolumeOptionParameters(option));
Line 424:         }
Line 425:         
Frontend.RunMultipleAction(VdcActionType.SetGlusterVolumeOption, list);
Line 426:     }


--
To view, visit http://gerrit.ovirt.org/7551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96397d30bc419ee1faa55d05451be862a766cda9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to