Ramesh N has posted comments on this change. Change subject: gluster: mark brick as down when port is N/A & TCP is enabled ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37941/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java: Line 205: Line 206: if (brick.containsKey(PORT)) { Line 207: if (StringUtils.isNumeric((String)brick.get(PORT))) { Line 208: brickProperties.setPort(Integer.parseInt((String) brick.get(PORT))); Line 209: } else if (volume.getTransportTypes().contains(TransportType.TCP)) { > Can you log this case? Done Line 210: //if there's no port registered, then the brick status is down. Line 211: brickProperties.setStatus(GlusterStatus.DOWN); Line 212: } Line 213: } -- To view, visit http://gerrit.ovirt.org/37941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957b5be043b60cc08bd3b0bba0426ccbf23f91ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
