Muli Salem has posted comments on this change. Change subject: core: Add validation for IP Addresses (#852076) ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java Line 16: Line 17: @Valid Line 18: private Network network; Line 19: Line 20: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_STATIC_IP_BAD_FORMAT") Perhaps this is an opportunity to fix the typo "NETWROK". Line 21: private String address; Line 22: Line 23: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_SUBNET_BAD_FORMAT") Line 24: private String subnet; Line 19: Line 20: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_STATIC_IP_BAD_FORMAT") Line 21: private String address; Line 22: Line 23: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_SUBNET_BAD_FORMAT") same here. Line 24: private String subnet; Line 25: private Integer vlanId; Line 26: Line 27: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_GATEWAY_BAD_FORMAT") Line 23: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_SUBNET_BAD_FORMAT") Line 24: private String subnet; Line 25: private Integer vlanId; Line 26: Line 27: @Pattern(regexp = ValidationUtils.IP_PATTERN, message = "NETWROK_ADDR_IN_GATEWAY_BAD_FORMAT") same here. Line 28: private String gateway; Line 29: private String bondingOptions; Line 30: private NetworkBootProtocol privateBootProtocol = NetworkBootProtocol.None; Line 31: -- To view, visit http://gerrit.ovirt.org/7636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I883deb575455c0cc2d0b7d45619a007421766df7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
