Muli Salem has posted comments on this change.
Change subject: core: Remove IP validation check from repetitive con (#852076)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java
Line 18: Collection<String> staticIps = new HashSet<String>();
Line 19: for (VdsNetworkInterface networkInterface : value) {
Line 20: String address = networkInterface.getAddress();
Line 21: if (networkInterface.getBootProtocol() ==
NetworkBootProtocol.StaticIp
Line 22: && address != null && !"".equals(address)) {
Perhaps change to address.isEmpty();
Line 23: if (staticIps.contains(networkInterface.getAddress()))
{
Line 24: return false;
Line 25: } else {
Line 26: staticIps.add(networkInterface.getAddress());
--
To view, visit http://gerrit.ovirt.org/7635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc8e065d36c57f1a7c71fc373ce00748ff26b41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
