Martin Mucha has posted comments on this change. Change subject: engine: remove EnumTranslator null warning message ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/38007/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java: Line 20 Line 21 Line 22 Line 23 Line 24 as I said in mailing list. I cannot see, why there should be localization of enum value. Enum value can be stored in variable and variable can be badly initialized. Then we're not able to differentiate between user not providing value and programmers fault. Alternative to removing warning, which is there because pessimistic expectation of programmers faults, is either creating new method with clear intention demonstration of "yes, I want to localize null key" or creating new enum value with meaning NOT_SET. But if that's too hard, or our developers don't do mistakes ;) we can just remove warning. -- To view, visit http://gerrit.ovirt.org/38007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87b0d08099909aabc12acb4582b15cbce70cded7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
