Alon Bar-Lev has posted comments on this change. Change subject: core, userportal, webadmin: VirtIO console access key management ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/35810/4/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java: Line 211: Line 212: return true; Line 213: } Line 214: Line 215: public static boolean isPublicKeyValid(String publicKey) { not sure why we need this put whatever you want... the role of the proxy is to check this out. there is no reason to limit rsa nor anything else, but the proxy will actually take care of it using simple re. Line 216: String[] words = publicKey.split("\\s+", 3); Line 217: Line 218: if (!words[0].equals(SSH_RSA)) { Line 219: return false; -- To view, visit http://gerrit.ovirt.org/35810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
