Arik Hadas has uploaded a new change for review. Change subject: core: replace ImportVmCommandBase#init with postConstruct ......................................................................
core: replace ImportVmCommandBase#init with postConstruct Change-Id: I34274806d69a80d55110282ec2ef69bfb7891593 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 3 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/38020/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java index ebb3289..89f2bae 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java @@ -117,8 +117,9 @@ } @Override - protected void init(T parameters) { - super.init(parameters); + protected void postConstruct() { + super.postConstruct(); + T parameters = getParameters(); setVmId(parameters.getContainerId()); setVm(parameters.getVm()); setVdsGroupId(parameters.getVdsGroupId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java index 77cf659..c736ccf 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java @@ -54,7 +54,6 @@ ImportVmCommandBase(T parameters, CommandContext commandContext) { super(parameters, commandContext); - init(parameters); } ImportVmCommandBase(Guid commandId) { @@ -76,9 +75,10 @@ return null; } - protected void init(T parameters) { - setStoragePoolId(parameters.getStoragePoolId()); - imageToDestinationDomainMap = parameters.getImageToDestinationDomainMap(); + @Override + protected void postConstruct() { + setStoragePoolId(getParameters().getStoragePoolId()); + imageToDestinationDomainMap = getParameters().getImageToDestinationDomainMap(); } /** diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java index 213b6f1..292cbfc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java @@ -68,7 +68,7 @@ } @Override - protected void init(T parameters) { + protected void postConstruct() { VM vmFromConfiguration = getParameters().getVm(); if (vmFromConfiguration != null) { vmFromConfiguration.getStaticData().setVdsGroupId(getParameters().getVdsGroupId()); @@ -82,7 +82,7 @@ setVdsGroupId(getParameters().getVdsGroupId()); getParameters().setStoragePoolId(getVdsGroup().getStoragePoolId()); - super.init(parameters); + super.postConstruct(); } private void initUnregisteredVM() { -- To view, visit http://gerrit.ovirt.org/38020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34274806d69a80d55110282ec2ef69bfb7891593 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
