Arik Hadas has uploaded a new change for review. Change subject: core: allow to override added VmDynamic on import ......................................................................
core: allow to override added VmDynamic on import Extract the VmDynamic creation which is added on import operation into a separate method so it could be changed by sub-commands. In particular, we need to change the status of the VM we add while importing it from external provider to be Down instead of ImageLocked. Change-Id: If888e8c1b39c838d717fe3f6919aa9450d8c02a9 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 1 file changed, 13 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/38033/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java index 561e7e5..384c125 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java @@ -371,18 +371,23 @@ } private void addVmDynamic() { - VmDynamic tempVar = new VmDynamic(); - tempVar.setId(getVmId()); - tempVar.setStatus(VMStatus.ImageLocked); - tempVar.setVmHost(""); - tempVar.setVmIp(""); - tempVar.setVmFQDN(""); - tempVar.setLastStopTime(new Date()); - tempVar.setAppList(getParameters().getVm().getDynamicData().getAppList()); + VmDynamic tempVar = createVmDynamic(); getVmDynamicDAO().save(tempVar); getCompensationContext().snapshotNewEntity(tempVar); } + protected VmDynamic createVmDynamic() { + VmDynamic vmDynamic = new VmDynamic(); + vmDynamic.setId(getVmId()); + vmDynamic.setStatus(VMStatus.ImageLocked); + vmDynamic.setVmHost(""); + vmDynamic.setVmIp(""); + vmDynamic.setVmFQDN(""); + vmDynamic.setLastStopTime(new Date()); + vmDynamic.setAppList(getParameters().getVm().getAppList()); + return vmDynamic; + } + private void addVmStatistics() { VmStatistics stats = new VmStatistics(); stats.setId(getVmId()); -- To view, visit http://gerrit.ovirt.org/38033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If888e8c1b39c838d717fe3f6919aa9450d8c02a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
