Oved Ourfali has posted comments on this change. Change subject: engine: ManageDomainsResult prints null when setConfigValue fails (#818479) ......................................................................
Patch Set 2: (1 inline comment) .................................................... Commit Message Line 11: of strings instead of sending all params to ctor. The ctor reads Line 12: those params and thinks that He gets only 1 param instead of 2. Line 13: The result is a print of default message instead of the formatted Line 14: message. Line 15: I'd change it to: 1. In ConfigurationProvider we thorw ManageDomainsResult, initialized with a list of strings instead initializing it with the entry, and the error, as two separate arguments. This results in printing a default message instead of the real one. Line 16: 2. ManageDomainsResult didn't override getMessage method. Line 17: Line 18: 3. The output for ManageDomainsResult with no default message was Line 19: changed to include also enumResult message. -- To view, visit http://gerrit.ovirt.org/7627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
