Doron Fediuck has posted comments on this change. Change subject: core: Sysprep can not handle values with dollar ......................................................................
Patch Set 2: I would prefer that you didn't submit this Tomas, extending compat.StringBuilderCompat may be problematic, since the whole compat area should go away one day. Can you please check if: 1. We can replace StringBuilderCompat with a simple StringBuilder? 2. Make the fix use StringBuilder and quoting? -- To view, visit http://gerrit.ovirt.org/7545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e93afea963c3f69cbabaf413ffebb5c7a7e0b51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
