Yaniv Bronhaim has uploaded a new change for review. Change subject: [WIP] core: delete last domain fails with engine-manage-domain (#851069) ......................................................................
[WIP] core: delete last domain fails with engine-manage-domain (#851069) Setting AdUserPassword to empty string was not validate, because this value type is CompositePassword, CompositePassword is defined to be structured as username:password. CompositePasswordValueHelper:valid method is verifing it. Now it lets us also assign empty string to CompositePassword. Change-Id: I9d4904a916f2055288e99114f2f267face16797b Signed-off-by: Yaniv Bronhaim <[email protected]> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/7604/1 diff --git a/backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java b/backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java index 307f863..8f6046a 100644 --- a/backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java +++ b/backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java @@ -27,6 +27,10 @@ @Override public String setValue(String value) throws Exception { + // Happens only when deleting password value + if (value.isEmpty()){ + return ""; + } value = pwdValueHelper.extractPasswordValue(value); return reformatKeyVal(value, ReformatType.ENCRYPT); } -- To view, visit http://gerrit.ovirt.org/7604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d4904a916f2055288e99114f2f267face16797b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
