Martin Mucha has posted comments on this change. Change subject: engine: Add host poller for setup network actions ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/34970/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java: Line 34: } Line 35: Line 36: waitBeforeNextPoll(timeBeforePoll); Line 37: } catch (TimeoutException e) { Line 38: // ignore failure. network can go down due to VDSM changing the network. No need to suspend between polls is there probably should be at least log; can be even very fine level, but we can turn it (on even on clients machine) if something is really wrong and we need to do that (anyhow improbable it may sound) Line 39: // timeout has reached. Line 40: } Line 41: Line 42: return false; Line 46: if (System.currentTimeMillis() - timeBeforePoll < POLLING_BREAK) { Line 47: try { Line 48: Thread.sleep(POLLING_BREAK); Line 49: } catch (InterruptedException e) { Line 50: // ignore. same. Line 51: } Line 52: } Line 53: } -- To view, visit https://gerrit.ovirt.org/34970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic11e71f0ee4e4ed4d6ae9a1d8fe4e5613da7a48f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
