Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Restore volume snapshot with georep case ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38150/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java: Line 205: > What if it fails in between? That is, slave volumes are restored but fails I feel even if master restore fails we should try to resume the geo-rep sessions so that slave volumes later can come to master state. The only issue would be that slave snapshots are deleted by that time as slave snapshots were restored successfully. User would not be able to restore to that state later from master in that case as slaves dont have that snapshot. Should we delete the master snapshot as well in this case? Not sure :( -- To view, visit https://gerrit.ovirt.org/38150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eccbcd4aa3e218ba0d910bd9150bdb0baa2db68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
