Gilad Chaplik has posted comments on this change. Change subject: core: use NumaPlacement instead of weird Pairs ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38048/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 866: Line 867: // check single node pinned Line 868: if (vmNumaNodes != null && vmNumaNodes.size() == 1 Line 869: && vmNumaNodes.get(0).getNumaPlacements().size() == 1 Line 870: && vmNumaNodes.get(0).getNumaPlacements().iterator().next().isPinned()) { you skipped null check, and a check that there's only one pinned node. Line 871: return ValidationResult.VALID; Line 872: } Line 873: Line 874: return new ValidationResult(VdcBllMessages.VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE); https://gerrit.ovirt.org/#/c/38048/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java: Line 86 Line 87 Line 88 Line 89 Line 90 this check make sure that you will set a pNode (uuid or index), but now if a user won't set nothing, we'll set it to 0 (default value). -- To view, visit https://gerrit.ovirt.org/38048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27a8f369e9896faeddd1e361ec884bf2c049b98f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
