Allon Mureinik has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 23: (3 comments) https://gerrit.ovirt.org/#/c/35277/23/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1189: onSaveSanStorage(); Line 1190: } Line 1191: } Line 1192: Line 1193: private void saveMostStorageProperties(StorageModel model) { > This one and SaveStorageProperties are the two I can think of. The latter s how about "saveCommonStorageProperties"? Line 1194: boolean isNew = model.getStorage() == null; Line 1195: storageDomain.setStorageType(isNew ? storageModel.getType() : storageDomain.getStorageType()); Line 1196: storageDomain.setStorageDomainType(isNew ? storageModel.getRole() : storageDomain.getStorageDomainType()); Line 1197: storageDomain.setDescription(model.getDescription().getEntity()); https://gerrit.ovirt.org/#/c/35277/23/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java: Line 211: setElementVisibility(retransmissionsLabel, object.getRetransmissions().getIsAvailable()); Line 212: setElementVisibility(timeoutLabel, object.getTimeout().getIsAvailable()); Line 213: setElementVisibility(mountOptionsLabel, object.getMountOptions().getIsAvailable()); Line 214: Line 215: // When all advanced fields are unavailable - hide the expander. > Have no idea, I thought I got rid of that. no harm done - just please fix it next round Line 216: boolean anyField = object.getVersion().getIsAvailable() Line 217: || object.getRetransmissions().getIsAvailable() Line 218: || object.getTimeout().getIsAvailable() Line 219: || object.getMountOptions().getIsAvailable(); https://gerrit.ovirt.org/#/c/35277/23/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 873: select fn_db_delete_config_value('FreeSpaceCriticalLow','general'); Line 874: select fn_db_delete_config_value('GlusterRefreshRateGeoRepStatus', 'general'); Line 875: select fn_db_delete_config_value('GlusterRefreshRateGeoRepDiscovery', 'general'); Line 876: select fn_db_delete_config_value('FreeSpaceCriticalLowInGB','general'); Line 877: select fn_db_delete_config_value('FreeSpaceLow','general'); > I was taking FreeSpaceCriticalLow's (line 873) lead. Yes - iiuc, you're logically attempting to rename a conf value. This will remove the old one and add a new one, losing any customization a user made in the process. Line 878: select fn_db_delete_config_value('HotPlugUnsupportedOsList','general'); Line 879: select fn_db_delete_config_value('HotPlugSupportedOsList','general'); Line 880: select fn_db_delete_config_value('ImagesSyncronizationTimeout','general'); Line 881: select fn_db_delete_config_value('keystorePass','general'); -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
