Ramesh N has posted comments on this change.

Change subject: engine: sync job for gluster disk provisioning
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/36429/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java:

Line 62:                 }
Line 63:             });
Line 64:         }
Line 65: 
Line 66:         if (storageDevicesListCalls != null) {
> either if (!storageDevicesListCalls.isEmpty())
Done
Line 67:             List<Pair<VDS, List<StorageDevice>>> storageDevices = 
ThreadPoolUtil.invokeAll(storageDevicesListCalls);
Line 68:             for (Pair<VDS, List<StorageDevice>> pair : storageDevices) 
{
Line 69:                 if (pair.getSecond() != null) {
Line 70:                     updateStorageDevices(pair.getFirst(), 
pair.getSecond());


-- 
To view, visit https://gerrit.ovirt.org/36429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I651bb51873a96d491c5a5f51147cb72be958985a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to