Itamar Heim has posted comments on this change.
Change subject: webadmin: sort iso images list
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
Line 182: ArrayList<String> fileNameList = new ArrayList<String>();
Line 183: for (RepoFileMetaData RepoFileMetaData : isoImages) {
Line 184: fileNameList.add(RepoFileMetaData.getRepoFileName());
Line 185: }
Line 186: Collections.sort(fileNameList, new
Linq.CaseInsensitiveComparer());
why sort on client side, instead of fixing the query to do order by for the
common use case of sorting by image name?
Line 187:
Line 188: for (String item : fileNameList) {
Line 189: EntityModel model = new EntityModel();
Line 190: model.setHashName(item);
--
To view, visit http://gerrit.ovirt.org/7633
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eab5186b92efcf8d49d788b4bff59794dc1560e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
