Sandro Bonazzola has posted comments on this change. Change subject: Add clean shutdown flag and checksum to the published metadata ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38276/1/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 704: tokens.append(self._hostname) Line 705: # Local maintenance flag Line 706: tokens.append(1 if md["maintenance"] else 0) Line 707: # Agent stopped cleanly flag Line 708: tokens.append(1 if "stopped" in md and md["stopped"] else 0) not sure about the above line. PEP recommendation was to enclose the construct with parenthesis while assigning to variable like: a = (1 if .. else 0) so Not sure if in this case it should be: tokens.append((1 if... else 0)) Line 709: # CRC32 in hex (use 0 for computing the crc) Line 710: tokens.append(metadata.EMPTY_CRC32) Line 711: Line 712: data = "|".join(str(t) for t in tokens) -- To view, visit https://gerrit.ovirt.org/38276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcc3a345a08a03e95edcbdf9f3c6f7e6fa1a5fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
