Moti Asayag has posted comments on this change.

Change subject: Revert "core: Make DAOs injectable"
......................................................................


Patch Set 2:

Host monitoring fails with inability to inject proper initialized dao objects:

 2015-03-02 16:37:20,818 WARN [org.ovirt.engine.core.vdsbroker.VdsManager] 
(DefaultQuartzScheduler_Worker-25) [] Failed to refresh VDS , vds = 
'masayag-f20-h1.usersys.redhat.com' : '638ab850-698a-4b35-b038-a2f6b1d63ddd', 
error = 'null', continuing. 2015-03-02 16:37:20,819 ERROR 
[org.ovirt.engine.core.vdsbroker.VdsManager] (DefaultQuartzScheduler_Worker-25) 
[] Exception: java.lang.NullPointerException at 
org.ovirt.engine.core.dao.BaseDAODbFacade.getCallsHandler(BaseDAODbFacade.java:104)
 [dal.jar:] at 
org.ovirt.engine.core.dao.network.NetworkDaoDbFacadeImpl.getManagementNetwork(NetworkDaoDbFacadeImpl.java:149)
 [dal.jar:] at 
org.ovirt.engine.core.bll.network.cluster.ManagementNetworkUtilImpl.getManagementNetwork(ManagementNetworkUtilImpl.java:37)
 [bll.jar:] at 
org.ovirt.engine.core.bll.network.cluster.ManagementNetworkUtilImpl.isManagementNetwork(ManagementNetworkUtilImpl.java:61)
 [bll.jar:] at 
org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerObjectsBuilder.updateNetworkDetai!
 lsInInterface(VdsBrokerObjectsBuilder.java:1698) [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerObjectsBuilder.addHostNetworksAndUpdateInterfaces(VdsBrokerObjectsBuilder.java:1436)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerObjectsBuilder.updateNetworkData(VdsBrokerObjectsBuilder.java:1409)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerObjectsBuilder.updateVDSDynamicData(VdsBrokerObjectsBuilder.java:621)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.vdsbroker.GetCapabilitiesVDSCommand.executeVdsBrokerCommand(GetCapabilitiesVDSCommand.java:17)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerCommand.executeVDSCommand(VdsBrokerCommand.java:101)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.VDSCommandBase.executeCommand(VDSCommandBase.java:55)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:33) 
[dal.jar:] at org.ovirt.engine.co!
 re.vdsbroker.ResourceManager.runVdsCommand(ResourceManager.java:462) 
[vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.VdsManager.refreshCapabilities(VdsManager.java:589)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.HostMonitoring.beforeFirstRefreshTreatment(HostMonitoring.java:690)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.HostMonitoring.refreshVdsRunTimeInfo(HostMonitoring.java:120)
 [vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.HostMonitoring.refresh(HostMonitoring.java:76) 
[vdsbroker.jar:] at 
org.ovirt.engine.core.vdsbroker.VdsManager.onTimer(VdsManager.java:202) 
[vdsbroker.jar:] at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source) 
[:1.7.0_71] at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 [rt.jar:1.7.0_71] at java.lang.reflect.Method.invoke(Method.java:606) 
[rt.jar:1.7.0_71] at 
org.ovirt.engine.core.utils.timer.JobWrapper.execute(JobWrapper.java:60) 
[scheduler.jar:] at org.quartz.core.JobRunShel
 l.run(JobRunShell.java:213) [quartz.jar:] at org.quartz.simpl.SimpleTh!
 readPool$WorkerThread.run(SimpleThreadPool.java:557) [quartz.jar:]

-- 
To view, visit https://gerrit.ovirt.org/38285
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bc2b087bf823a9d6be2327c999062563c9b0c6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to