Daniel Erez has posted comments on this change. Change subject: webadmin: StorageListModel: refactorig storage prepare for edit. ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/38128/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LocalStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LocalStorageModel.java: Line 47: public void setRole(StorageDomainType value) { Line 48: role = value; Line 49: } Line 50: Line 51: @Override protected void prepareConnectionForEditing(StorageServerConnections connection) {} just convention - move the annotation to a separate line Line 52: Line 53: public LocalStorageModel() { Line 54: setUpdateCommand(new UICommand("Update", this)); //$NON-NLS-1$ Line 55: setPath(new EntityModel<String>()); https://gerrit.ovirt.org/#/c/38128/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java: Line 283: Line 284: @Override Line 285: public void prepareForEdit(StorageDomain storage) { Line 286: getOverride().setIsChangable(isEditable(storage)); Line 287: super.prepareForEdit(storage); can super be called first? Line 288: } https://gerrit.ovirt.org/#/c/38128/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java: Line 672: return getContainer().isStorageActive() || getContainer().isNewStorage(); Line 673: } Line 674: Line 675: public void prepareForEdit(final StorageDomain storage) Line 676: { move to eol Line 677: if (isEditable(storage)) { Line 678: final SanStorageModel thisModel = this; Line 679: getContainer().getHost().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { Line 680: @Override Line 688: } Line 689: } Line 690: Line 691: private void postPrepareSanStorageForEdit(final SanStorageModel model, boolean isStorageActive, StorageDomain storage) Line 692: { move to eol Line 693: model.setStorageDomain(storage); Line 694: Line 695: VDS host = getContainer().getHost().getSelectedItem(); Line 696: Guid hostId = host != null && isStorageActive ? host.getId() : null; -- To view, visit https://gerrit.ovirt.org/38128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
