Sandro Bonazzola has posted comments on this change. Change subject: infra: Alert/Abandon old Gerrit patches ......................................................................
Patch Set 9: Code-Review+1 (1 comment) Code looks good, I suggest to address Itamar's comment by explaining a bit more about what the script does in the comment or even better in the module docstring. https://gerrit.ovirt.org/#/c/37426/9/scripts/alert_old_patches.py File scripts/alert_old_patches.py: Line 81: return out Line 82: Line 83: if __name__ == "__main__": Line 84: Line 85: PARSER = argparse.ArgumentParser() you're using capitalized names for non-constant values, but since this it module level I guess pylint complained about it. It's ok for me. Line 86: PARSER.add_argument( Line 87: "projects", help="List of projects", Line 88: nargs='+') Line 89: PARSER.add_argument( -- To view, visit https://gerrit.ovirt.org/37426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic911411a61e097c734d0199cc04057c393b974f9 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Vishnu Sreekumar <[email protected]> Gerrit-Reviewer: Barak Korren <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Vishnu Sreekumar <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
