Moti Asayag has uploaded a new change for review. Change subject: core: Cleaup AddVmPoolWithVmsParameters ......................................................................
core: Cleaup AddVmPoolWithVmsParameters Change-Id: I562ca8faf5fbdfcbadbea1c0f7f5439ca05560f4 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java 1 file changed, 12 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/38345/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java index 0c24bd0..81c9823 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java @@ -2,24 +2,25 @@ import java.util.HashMap; import java.util.Map; + import javax.validation.Valid; import org.ovirt.engine.core.common.businessentities.DiskImage; import org.ovirt.engine.core.common.businessentities.GraphicsDevice; import org.ovirt.engine.core.common.businessentities.GraphicsType; import org.ovirt.engine.core.common.businessentities.VM; +import org.ovirt.engine.core.common.businessentities.VmPool; import org.ovirt.engine.core.common.businessentities.VmRngDevice; import org.ovirt.engine.core.common.businessentities.VmStatic; -import org.ovirt.engine.core.common.businessentities.VmPool; import org.ovirt.engine.core.compat.Guid; public class AddVmPoolWithVmsParameters extends VmPoolOperationParameters implements HasGraphicsDevices { private static final long serialVersionUID = 4826143612049185740L; @Valid - private VM _vm; - private int _vmsCount; - private int _diskSize; + private VM vm; + private int vmsCount; + private int diskSize; private HashMap<Guid, DiskImage> diskInfoDestinationMap; private Boolean soundDeviceEnabled; private Boolean consoleEnabled; @@ -29,32 +30,27 @@ private Map<GraphicsType, GraphicsDevice> graphicsDevices; public AddVmPoolWithVmsParameters() { - init(); } - public AddVmPoolWithVmsParameters(VmPool vmPool, VM vm, int count, int diskSize) { + public AddVmPoolWithVmsParameters(VmPool vmPool, VM vm, int vmsCount, int diskSize) { super(vmPool); - init(); - _vm = vm; - _vmsCount = count; - _diskSize = diskSize; - } - - private void init() { graphicsDevices = new HashMap<GraphicsType, GraphicsDevice>(); + this.vm = vm; + this.vmsCount = vmsCount; + this.diskSize = diskSize; } @Valid public VmStatic getVmStaticData() { - return _vm.getStaticData(); + return vm.getStaticData(); } public int getVmsCount() { - return _vmsCount; + return vmsCount; } public int getDiskSize() { - return _diskSize; + return diskSize; } public HashMap<Guid, DiskImage> getDiskInfoDestinationMap() { -- To view, visit https://gerrit.ovirt.org/38345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I562ca8faf5fbdfcbadbea1c0f7f5439ca05560f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
