Alon Bar-Lev has posted comments on this change. Change subject: packaging: Check JVM version before starting (#834436) ......................................................................
Patch Set 6: I don't think we should have this one if we do: http://gerrit.ovirt.org/#/c/7549/ Or... move these into common code, both can include... if missing from setup, use same algorithm to runtime detect java. I like it as I don't think the setup should override java unless explicit requested by the user. And this way we can use distro specific tool in runtime, But, if it just checks for version I don't think it is required. -- To view, visit http://gerrit.ovirt.org/5894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13b2daa54cfce6f9a5e3e50a76667132acc05465 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
