Eldan Shachar has posted comments on this change. Change subject: core/restapi/webadmin: Support clearing the cluster's emulated machine ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/37115/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 522: list.add(vdsGroup.getName()); Line 523: } Line 524: model.setItems(list); Line 525: Line 526: UICommand applyCommand = new UICommand("OnResetClusterEmulatedMachine", this); //$NON-NLS-1$ > there is a patch merged recently introducing factory methods simplifying th Done Line 527: applyCommand.setTitle(ConstantsManager.getInstance().getConstants().ok()); Line 528: applyCommand.setIsDefault(true); Line 529: model.getCommands().add(applyCommand); Line 530: UICommand cancelCommand = new UICommand("Cancel", this); //$NON-NLS-1$ https://gerrit.ovirt.org/#/c/37115/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java: Line 64: Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider, Line 65: final Provider<ClusterPopupPresenterWidget> popupProvider, Line 66: final Provider<GuidePopupPresenterWidget> guidePopupProvider, Line 67: final Provider<RemoveConfirmationPopupPresenterWidget> removeConfirmPopupProvider, Line 68: final Provider<DefaultConfirmationPopupPresenterWidget> resetEmulatedMachineConfirmPopupProvider, > this should not be needed - you could use the defaultConfirmPopupProvider Done. Had to make the default provider final for this.. Line 69: final Provider<ReportPresenterWidget> reportWindowProvider, Line 70: final Provider<MultipleHostsPopupPresenterWidget> addMultipleHostsPopupProvider, Line 71: final Provider<ClusterListModel> clusterProvider, Line 72: final Provider<CommonModel> commonModelProvider) { -- To view, visit https://gerrit.ovirt.org/37115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
