Michal Skrivanek has posted comments on this change. Change subject: core: Refresh number of in/out migrations in HostMonitoring ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38325/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 762: } Line 763: } Line 764: Line 765: void refreshInOutMigrations() { Line 766: if (!vdsManager.getRefreshStatistics()) { > If I understand the code, this condition is a protection against calling re indeed. I also don't see how that change can help. I think Gilad's change 36970 should be revisited/reverted/explained Line 767: return; Line 768: } Line 769: Line 770: int incomingMigrations = 0; -- To view, visit https://gerrit.ovirt.org/38325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1ef858a6faf861678245cc02006f40dd230602 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
