Muli Salem has posted comments on this change.

Change subject: core: PlugUnplug to ActivateDeactivate (#850854)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java
Line 36:     protected boolean canDoAction() {
Line 37:         boolean returnValue = true;
Line 38: 
Line 39:         if 
(isActivateDeactivateAllowedForVmStatus(getVm().getstatus())) {
Line 40:             // Hot activation in the host needs to be called only if 
the Vm is UP
Done
Line 41:             if 
(VmHandler.isHotPlugNicAllowedForVmStatus(getVm().getstatus())) {
Line 42:                 setVdsId(getVm().getrun_on_vds().getValue());
Line 43:                 returnValue = canPerformHotPlug();
Line 44:                 if (returnValue && 
!networkAttachedToVds(getNetworkName(), getVdsId())) {


--
To view, visit http://gerrit.ovirt.org/7667
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a879dca5c0303c0e25c76a2bc4bf1046578679a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to