Fred Rolland has posted comments on this change. Change subject: webadmin: Create VM from Templates list view ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/38286/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java: Line 617: private void onSaveVm() { Line 618: UnitVmModel model = (UnitVmModel) getWindow(); Line 619: String name = model.getName().getEntity(); Line 620: setcurrentVm(new VM()); Line 621: validateVM(model, name); > for consistency reason with the prev line please use "validateVm" (small "m Done Line 622: } Line 623: Line 624: public void postNameUniqueCheck(boolean isNameUnique) Line 625: { https://gerrit.ovirt.org/#/c/38286/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java: Line 84: cluster.setStoragePoolId(currentTemplate.getStoragePoolId()); Line 85: DataCenterWithCluster dataCenterWithCluster = Line 86: new DataCenterWithCluster(null, cluster); Line 87: model.getDataCenterWithClustersList().setItems(Arrays.asList(dataCenterWithCluster)); Line 88: model.getDataCenterWithClustersList().setSelectedItem(dataCenterWithCluster); > this else block makes sense in the existingVm/pool etc branches since you c Done Line 89: } Line 90: Line 91: } Line 92: }), -- To view, visit https://gerrit.ovirt.org/38286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e5fd7e84bbea9405bf7d9e087b4281866daa954 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
