Arik Hadas has posted comments on this change. Change subject: core: cow-sparse base volumes of templates ......................................................................
Patch Set 1: raw+sparse on block devices is handled by CreateImageTemplateCommand#getTargetVolumeFormat (the format is converted to cow). Basically you're right, but I think it's better that the clients won't send the type. Clients will just send format + destination storage and the engine will set the type. what do you think? -- To view, visit https://gerrit.ovirt.org/38376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ed39f0360c09799581f146b282e7ccadd1109d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
