Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: setting an ISO image for cloud-init configuration ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38350/6/src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py File src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py: Line 231: subst[self.BOOT_DEVICE[key]] = ',bootOrder:1' Line 232: Line 233: if self.environment[ Line 234: ohostedcons.VMEnv.CDROM Line 235: ]: > Are you sure this work without the check against none? You may have empty s I think it works as expected: if it gets None, False or '', it use subst['@CDROM@'] = '' so it doesn't attach any CD, otherwise if we have a path we honor it. Line 236: subst['@CDROM@'] = self.environment[ Line 237: ohostedcons.VMEnv.CDROM Line 238: ] Line 239: else: -- To view, visit https://gerrit.ovirt.org/38350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a2cce9c47f4e6a6279dcb1657dbbcc9a3e5f04e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
