Tomas Jelinek has posted comments on this change. Change subject: core: Allow creation of new disks as copy of any existing disk ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38334/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 335: Guid newGroupId = Guid.newGuid(); Line 336: Line 337: DiskImage image = getImage(); Line 338: Line 339: image.setId(newGroupId); > Since when copying a template disk we preserve the old id and just add a ne ok, changed in a way that only the copy VM disks are different - reflected also on the frontend Line 340: image.setImageId(newId); Line 341: Line 342: image.setDiskAlias(getDiskAlias()); Line 343: image.setStorageIds(new ArrayList<Guid>()); -- To view, visit https://gerrit.ovirt.org/38334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07eece05b1880011f1a1b4300d07f0bd1ebf30bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
