Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: new tooltip infrastructure ......................................................................
Patch Set 17: Code-Review+1 (1 comment) Looks good to me, basically +2 from me but want Vojtect to take a look https://gerrit.ovirt.org/#/c/36597/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java: Line 44: * </p> Line 45: * Line 46: * @author Joshua Godi Line 47: * @author Pontus Enmark Line 48: * @author Greg Sheremeta We don't have any @author in any of our classes. Line 49: */ Line 50: public class ElementTooltip implements HasId, HasHover { Line 51: private static final String TOGGLE = "toggle"; //$NON-NLS-1$ Line 52: private static final String SHOW = "show"; //$NON-NLS-1$ -- To view, visit https://gerrit.ovirt.org/36597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie60ebe16e2d8830498fd819ffdb39aa043daadd2 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
