Einav Cohen has posted comments on this change. Change subject: webadmin: no auto logout when idle ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/37837/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java: Line 211: return Backend.getInstance(); Line 212: } Line 213: Line 214: protected VdcQueryReturnValue runInternalQuery(VdcQueryType actionType, VdcQueryParametersBase parameters) { Line 215: //All internal queries should have refresh set to false, since that is an UI only thing. I wouldn't call it a UI thing - maybe a 'client thing'; only the engine-client (whether it is a UI or not) should decide whether the engine session should be kept alive or not. The engine should not be allowed to make (or modify) that decision. Line 216: parameters.setRefresh(false); Line 217: return getBackend().runInternalQuery(actionType, parameters, getEngineContext()); Line 218: } Line 219: -- To view, visit https://gerrit.ovirt.org/37837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b9ea108ddca3d2d137860b9425691ffc0a95ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
