Sahina Bose has posted comments on this change. Change subject: engine : Bll Command for Create Geo Rep session ......................................................................
Patch Set 23: (3 comments) https://gerrit.ovirt.org/#/c/29834/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java: Line 27: Line 28: public CreateGlusterVolumeGeoRepSessionCommand(GlusterVolumeGeoRepSessionParameters params) { Line 29: super(params); Line 30: setGlusterVolumeId(getParameters().getVolumeId()); Line 31: session = getDbFacade().getGlusterGeoRepDao().getById(getParameters().getGeoRepSessionId()); for create session would geoRepSessionId exist in parameters? and there would be no session in db, right? Line 32: } Line 33: Line 34: @Override Line 35: protected void executeCommand() { Line 28: public CreateGlusterVolumeGeoRepSessionCommand(GlusterVolumeGeoRepSessionParameters params) { Line 29: super(params); Line 30: setGlusterVolumeId(getParameters().getVolumeId()); Line 31: session = getDbFacade().getGlusterGeoRepDao().getById(getParameters().getGeoRepSessionId()); Line 32: } canDoAction? Line 33: Line 34: @Override Line 35: protected void executeCommand() { Line 36: boolean rootSession = getParameters().getUserName() == "root"; Line 113: Line 114: private boolean writePubKeys(String pubKeys) { Line 115: GlusterVolumeGeoRepSessionParameters parameters = getParameters(); Line 116: Set<Guid> slaveVolumeServerIds = fetchSlaveServerIds(); Line 117: for (Guid currentSlaveHostId : slaveVolumeServerIds) { You could change to execute this is parallel using ThreadPool Line 118: getCustomValues().put(GlusterConstants.VDS_NAME, getVdsDAO().get(currentSlaveHostId).getName()); Line 119: VDSReturnValue writePubKeysReturnValue = Line 120: runVdsCommand(VDSCommandType.WritePubKeys, new WritePubKeysVDSParameters(currentSlaveHostId, Line 121: parameters.getUserName(), -- To view, visit https://gerrit.ovirt.org/29834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccc92235deea42d7818336b2402476193cbe789c Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
