Fabian Deutsch has submitted this change and it was merged. Change subject: engine_page: Catch exception KeyError ......................................................................
engine_page: Catch exception KeyError If VDSM is not ready to provide network data via vdscli.getVdsCaps()['info']['networks'] and fail with KeyError we should throw an error message and not stuck in the login. Additionally, for unexpected exceptions in vdscli we should log as error and not use raise to avoid users getting blocked into the login page. Change-Id: I4b7666c2020307c6119f96a2935684bc268e459b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198029 Signed-off-by: Douglas Schilling Landgraf <[email protected]> --- M src/engine_page.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Looks good to me, approved Douglas Schilling Landgraf: Verified -- To view, visit https://gerrit.ovirt.org/38428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b7666c2020307c6119f96a2935684bc268e459b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
