Alona Kaplan has posted comments on this change. Change subject: engine: adding maintenanceReason to vdsDynamic ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/38296/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-03 10:04:30 +0200 Line 4: Commit: Alona Kaplan <[email protected]> Line 5: CommitDate: 2015-03-03 13:18:09 +0200 Line 6: Line 7: engine: adding maintenacneReason to vdsDynamic > please fix typo in the next patch Done Line 8: Line 9: This patch includes- Line 10: 1. Adding the field to the business entity. Line 11: 2. Adding a column to the table. https://gerrit.ovirt.org/#/c/38296/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 15: import org.ovirt.engine.core.compat.Guid; Line 16: import org.ovirt.engine.core.compat.RpmVersion; Line 17: import org.ovirt.engine.core.compat.Version; Line 18: Line 19: public class VDS extends IVdcQueryable implements Serializable, BusinessEntityWithStatus<Guid, VDSStatus>, HasStoragePool<Guid>, Commented, Nameable, Cloneable, Reasoned { > it doesn't seem to me that Reasoned is the proper interface for this purpos Done Line 20: private static final long serialVersionUID = -7893976203379789926L; Line 21: private VdsStatic vdsStatic; Line 22: private VdsDynamic vdsDynamic; Line 23: private VdsStatistics vdsStatistics; https://gerrit.ovirt.org/#/c/38296/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 673: public String getMaintenanceReason() { Line 674: return maintenanceReason; Line 675: } Line 676: Line 677: public void setMaintenanceReason(String stopReason) { > please rename the parameter to maintenanceReason Done Line 678: this.maintenanceReason = stopReason; Line 679: } Line 680: Line 681: @Override -- To view, visit https://gerrit.ovirt.org/38296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac900c656e8309bf9f32fcc9fa9f5c32ed26298c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
