Martin Mucha has posted comments on this change. Change subject: core: AuditLogDirector should not have static methods ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/29589/16/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorDelegator.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorDelegator.java: Line 1: package org.ovirt.engine.core.dal.dbbroker.auditloghandling; Line 2: Line 3: import org.ovirt.engine.core.common.AuditLogType; Line 4: Line 5: public final class AuditLogDirectorDelegator implements AuditLogger { > now with the CDI we should get rid of this file. Done Line 6: Line 7: private static final AuditLogger instance = new AuditLogDirectorDelegator(); Line 8: private final AuditLogDirector auditLogDirector = new AuditLogDirector(); Line 9: -- To view, visit https://gerrit.ovirt.org/29589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id88ecd68fdc469bd0ddfdf4ae9c7f6d22ff8e8bf Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
