Martin Mucha has posted comments on this change. Change subject: core: DI for AuditLoggerDirector ......................................................................
Patch Set 3: removed delegator along with it's unused interface. I did search for AuditLogDirector instantiations and replaced it again with injections where possible. Notice that there are still places, where AuditLogDirector is created. I don't believe those places are managed objects, so I can only pass AuditLogDirector instance there or create one there. Please let me know, if you want to removed mentioned instantiations altogether. -- To view, visit https://gerrit.ovirt.org/33901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab56339a634234bbc51fa09719fb87b5cc69501 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
